feat!: remove curl factory override #86
Merged
+18
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oliboy50
approved these changes
Oct 13, 2023
| public function release(EasyHandle $easy): void | ||
| { | ||
| if (!is_null($easy->response)) { | ||
| $easy->response->curlInfo = curl_getinfo($easy->handle); |
There was a problem hiding this comment.
this info wasn't used/displayed in the data collector (i.e. Symfony devtools)?
(just asking to make sure we didn't miss something)
There was a problem hiding this comment.
As the property doesn't exist any more , I strongly doubt so... but I can try to have a look.
Looking far into guzzlehttp/psr7 (up to 2015), it was never a property
shavounet
force-pushed
the
feat/mark-deprecations-v5
branch
from
0e1d89a to
49a3e11
Compare
shavounet
force-pushed
the
feat/remove-curl-factory
branch
4 times, most recently
from
dc8cc70 to
a9314b8
Compare
shavounet
force-pushed
the
feat/remove-curl-factory
branch
2 times, most recently
from
d820759 to
0126cff
Compare
shavounet
changed the base branch from
feat/mark-deprecations-v5
to
update/dependencies
fferriere
approved these changes
Oct 16, 2023
shavounet
force-pushed
the
update/dependencies
branch
from
c5ab44a to
f61b4bc
Compare
shavounet
force-pushed
the
feat/remove-curl-factory
branch
from
0126cff to
0c247de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
The curlInfo dynamic property is deprecated in PHP8.2.
To fetch the same data use the native on_stat option
How?
Removed all trace of the curl factory. This will imply a new major version